chore(ci): revamp parallel test outputs clarity and conciseness - #18002
Draft
chalmerlowe wants to merge 4 commits into
Draft
chore(ci): revamp parallel test outputs clarity and conciseness#18002chalmerlowe wants to merge 4 commits into
chalmerlowe wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the package change detection and logging logic in .kokoro/system.sh. It introduces a states array to track whether a package has changed or is part of a continuous build, and formats these states into a comma-separated string for clearer logging output. I have no feedback to provide as there are no review comments.
Contributor
Author
|
Added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current output from the package checking phase (where we determine if a package should be tested OR not) in parallel
system testsis noisy and difficult to read. It prints internal debug commands and multiple lines of text for every package, making it hard to quickly scan and see which packages are being tested or skipped.Solution
This Pull Request revamps the output format of the package checking phase to be highly readable and aligned.
printf, making vertical scanning easy for humans and parsing easy for tools.Notes to Reviewers
packages/google-cloud-testutils/setup.pyto force this package to be tested in CI, allowing you to see the new output format in action. This will be removed before merging.Example Output
Pre-planning For Adhoc Testing:
While ad hoc testing is not yet merged to main and is not processed as a part of this PR, the expectation is that a future PR will refine this format when adhoc is added> At that time we will be able to determine why a TEST state was chosen (changed, adhoc, or both if a package has changes AND is inadvertantly included in the ad hoc list).